Generate IndexSettings types #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Xtansia
force-pushed
the
feat/code-gen/index-settings
branch
3 times, most recently
from
cf638b1
to
5d66ac5
Compare
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
feat/code-gen/index-settings
branch
from
5d66ac5
to
c3f2fa5
Compare
dblock
approved these changes
Nov 26, 2024
| - `totalFields` is now of type `IndexSettingsMappingLimitTotalFields`. | ||
|
|
||
| ### IndexSettings | ||
| - The `creationDate` property is now of type `Long` instead of `String`. |
There was a problem hiding this comment.
Is there an opportunity to evolve those to a strong DateTime?
There was a problem hiding this comment.
Have made an issue to address this in future: #1331
reta
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate IndexSettings types
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.